[Python-Dev] Patch Manager Guidelines

Guido van Rossum guido@digicool.com
Thu, 15 Mar 2001 11:44:54 -0500


> It appears that the Patch Manager Guidelines
> (http://python.sourceforge.net/sf-faq.html#a1) don't work with the new
> tracker tool anymore. They claim that the status of the patch can be
> Open, Accepted, Closed, etc - which is not true: the status can be
> only Open, Closed, or Deleted; Accepted is a value of Resolution.
> 
> I have to following specific questions: If a patch is accepted, should
> it be closed also? If so, how should the resolution change if it is
> also committed?

A patch should only be closed after it has been committed; otherwise
it's too easy to lose track of it.  So I guess the proper sequence is

1. accept; Resolution set to Accepted

2. commit; Status set to Closed

I hope the owner of the sf-faq document can fix it.

--Guido van Rossum (home page: http://www.python.org/~guido/)