[Python-Dev] Function Hash: Check it in?

[Finn Bock]

On Mon, 29 Jan 2001 16:04:47 +0200 (IST), you wrote:

>On Mon, 29 Jan 2001 13:48:44 GMT, bckfnn@worldonline.dk (Finn Bock) wrote:
> 
>> Thanks. With this change, Jython too can complete the test_opcodes. In
>> Jython a code object can never compare equal to anything but itself.
>
>Great! I'm happy to have helped.
>I'm starting to wonder what the tests really test: the language definition,
>or accidents of the implementation?

Based on the amount of code in test_opcodes dedicated to code
comparison, I doubt this particular situation was an accident.

The problems I have had with the test suite are better described as
accidents of the tests themself. From test_extcall:

  We expected (repr): "g() got multiple values for keyword argument 'b'"
  But instead we got: "g() got multiple values for keyword argument 'a'"

This is caused by a difference in iteration over a dictionary.

Or from test_import:

  test test_import crashed -- java.lang.ClassFormatError:
  java.lang.ClassFormatError: @test$py (Illegal Class name "@test$py")

where '@' isn't allowed in java classnames.

These are failures that have very little to do with the thing the test
are about and nothing at all to do with the language definition.

regards,
finn