[Python-Dev] Re: [Python-checkins] CVS: python/dist/src/Include pyport.h,2.24,2.25
Guido van Rossum
guido@digicool.com
Mon, 22 Jan 2001 10:06:06 -0500
> Move declaration of 'clnt_create()' NIS function to pyport.h, as it's
> supposed to be declared in system include files (with a proper prototype.)
> Should be moved to a platform-specific block if anyone finds out which
> broken platforms need it :-)
[The following is inside #if 0]
> + /* From Modules/nismodule.c */
> + CLIENT *clnt_create();
> +
Thomas, I'm not sure if this particular declaration belongs in
pyport.h, even inside #if 0.
CLIENT is declared in a NIS-specific header file that's not included by
pyport.h, but which *is* included by nismodule.c.
I think you did the right thing to nismodule.c; the pyport.h patch is
redundant in my eyes.
--Guido van Rossum (home page: http://www.python.org/~guido/)