[Python-Dev] SocketServer and UserDict patches

Guido van Rossum guido@digicool.com
Tue, 10 Apr 2001 22:29:31 -0500


> > > > > 2.  SocketServer.StreamRequestHandler
> [...]
> > Alas, this is still at the wrong level.  The get_request() method is
> > overridable (e.g. by the UDPServer class) and the request that it
> > returns may not have a close method.  The best I can come up with is
> > to add an empty method self.close_request(request) to the base class,
> > call it in handle_request(), and override it to call request.close()
> > in the TCPServer class.
> 
> Yes, i agree that's a good division of responsibilities.  See the
> updated patch.  I think it would be nice if it could go in, but it's
> up to you if you want to accept it.

I've accepted this and assigned it to you.  That means that *you*
should check it in!  (This is so that the CVS logs show the author of
the patch.)

--Guido van Rossum (home page: http://www.python.org/~guido/)