[Python-Dev] yeah! for Jeremy and Greg

[Ka-Ping Yee]

On Wed, 29 Mar 2000, Fredrik Lundh wrote:
> > I'm thrilled to see the extended call syntax patches go in!  One less wart
> > in the language!
> 
> but did he compile before checking in?

You beat me to it.  I read David's message and got so excited
i just had to try it right away.  So i updated my CVS tree,
did "make", and got the same error:

    make[1]: Entering directory `/home/ping/dev/python/dist/src/Python'
    gcc -g -O2 -I./../Include -I.. -DHAVE_CONFIG_H   -c compile.c -o compile.o
    compile.c: In function `com_call_function':
    compile.c:1225: `CALL_FUNCTION_STAR' undeclared (first use in this function)
    compile.c:1225: (Each undeclared identifier is reported only once
    compile.c:1225: for each function it appears in.)
    make[1]: *** [compile.o] Error 1

> (compile.c and opcode.h both mention this identifier, but
> nobody defines it...  should it be CALL_FUNCTION_VAR,
> perhaps?)

But CALL_FUNCTION_STAR is mentioned in the comments...

    #define CALL_FUNCTION   131     /* #args + (#kwargs<<8) */
    #define MAKE_FUNCTION   132     /* #defaults */
    #define BUILD_SLICE     133     /* Number of items */

    /* The next 3 opcodes must be contiguous and satisfy
       (CALL_FUNCTION_STAR - CALL_FUNCTION) & 3 == 1  */
    #define CALL_FUNCTION_VAR          140  /* #args + (#kwargs<<8) */
    #define CALL_FUNCTION_KW           141  /* #args + (#kwargs<<8) */
    #define CALL_FUNCTION_VAR_KW       142  /* #args + (#kwargs<<8) */

The condition (CALL_FUNCTION_STAR - CALL_FUNCTION) & 3 == 1
doesn't make much sense, though...


-- ?!ng