[Python-Dev] ANSIfication breaks socketmodule compile...

[Moshe Zadka]

On Mon, 24 Jul 2000, Mark Favas wrote:

> The recent bout of ANSIfication seems to have raised a couple of issues
> with socketmodule:
> 
> 1) It now won't compile on Tru64, because the declaration of
> "gethostname" on line 114 conflicts with that in the system unistd.h
> header file. 114 declares the second parameter as size_t, unistd.h
> declares it as int (unless the macro _XOPEN_SOURCE_EXTENDED is defined,
> but that's another can of worms...). The simple fix here is to add
> another !(defined(__osf__) to the preceding #if line.

Hmmmm....gethostname() prototype should probably be left to system
includes, and not defined at all (except maybe in pyport.h under heavy
#ifdef guard)

> 2) There'll be an issue on those platforms where the second parameter
> _is_ declared as type size_t, because the gethostname function is called
> at line 1402 with the second parameter cast to an int, rather than a
> size_t...

This is plain wrong! The cast should probably be deleted.

--
Moshe Zadka <moshez@math.huji.ac.il>
There is no IGLU cabal.
http://advogato.org/person/moshez