[python-committers] New workflow - some questions

[Paul Moore]

On 28 July 2017 at 23:30, Mariatta Wijaya <mariatta.wijaya at gmail.com> wrote:
>> 1. Section 32.2 in the Git bootcamp section - is there any reason to
>> use git at github URLs for the clones? I normally always use
>> https://github.com URLs, as they work with my proxy at work.
>
>
> I don't have any explanation other than Git bootcamp was initially written
> based on my personal setup.
> I cloned CPython using SSH, and that's what I wrote in the devguide :)
> You can use HTTPS if that works for you.
> Perhaps someone else can explain better the difference between cloning via
> HTTPS and SSH.

Thanks for the clarification - I doubt it matters much whether you use
https or git in practice. I've found https better for me because it's
more proxy friendly. I don't really know the differences because I've
never used git.

>> I generally use "Compare and create pull request"
>> from my clone's github page, as that seems simpler.
>
> Note that the link is only visible within 30 minutes (or so) after you
> pushed your branch to remote.

Ah - I didn't know that, When working on pip, I normally push and
create a PR in quick succession.

> If you did not create the PR immediately after pushing, the link disappears.
> In this case, the instructions in 32.10 will help (maybe?).

They will - a lot. Thanks.

> Can we assume that people will create their PR immediately?

Definitely not, in general.

> Maybe an improvement is to mention the "Compare and create pull request",
> and to do this immediately after pushing the branch.

It might be worth suggesting it as an option, simply so that if a
contributor sees the button, they know it's just an alternative
approach and it's OK to use. I'll see if I can think of some wording
that would help here.

> side-topic: Does anyone have some sort of script/git
> alias/program/whatchamacallit that will open the PR page once we push to
> remote? (similar to what cherry_picker does)  That could be a time saver :)

I don't - that's the sort of thing I just do manually. (I work on
multiple machines, so I'm heavily reliant on minimising the amount of
custom scripts and/or setup needed to work on a project. For me, a
simple, easily remembered workflow with minimal dependencies on
specialised tools works best.)

>> 3. The new blurb tool - I presume I'll need to set that up
>> somewhere/somehow, and use it to create a news entry. But I can't find
>> any docs on it at all :-(
>
> pip install blurb

Doh. I think I recall some discussion about using virtualenvs and
maybe that made me think something complex was needed. My mistake.

> Some write-up here:
> https://devguide.python.org/committing/#what-s-new-and-news-entries

Again doh - I don't know how I missed that, thanks.

> blurb readme:
> https://github.com/python/core-workflow/blob/master/blurb/README.rst

Paul