[Python-checkins] [3.12] Enable the ABI check job to publish the updated ABI data file (GH-105088)

zooba webhook-mailer at python.org
Tue May 30 12:31:58 EDT 2023


https://github.com/python/cpython/commit/4e7d41f9867676dc1aacdf0310f500b0191be0fc
commit: 4e7d41f9867676dc1aacdf0310f500b0191be0fc
branch: 3.12
author: Steve Dower <steve.dower at python.org>
committer: zooba <steve.dower at microsoft.com>
date: 2023-05-30T17:31:51+01:00
summary:

[3.12] Enable the ABI check job to publish the updated ABI data file (GH-105088)

files:
M .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3ada845c4cbb..046c2aaa55f6 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -100,15 +100,28 @@ jobs:
           ./configure --enable-shared
           make -j4
       - name: Check for changes in the ABI
+        id: check
         run: |
           if ! make check-abidump; then
             echo "Generated ABI file is not up to date."
             echo "Please add the release manager of this branch as a reviewer of this PR."
             echo ""
+            echo "The up to date ABI file should be attached to this build as an artifact."
+            echo ""
             echo "To learn more about this check: https://devguide.python.org/setup/#regenerate-the-abi-dump"
             echo ""
             exit 1
           fi
+      - name: Generate updated ABI files
+        if: ${{ failure() && steps.check.conclusion == 'failure' }}
+        run: |
+          make regen-abidump
+      - uses: actions/upload-artifact at v3
+        name: Publish updated ABI files
+        if: ${{ failure() && steps.check.conclusion == 'failure' }}
+        with:
+          name: abi-data
+          path: ./Doc/data/*.abi
 
   check_generated_files:
     name: 'Check if generated files are up to date'



More information about the Python-checkins mailing list