[Python-checkins] GH-101291: Avoid using macros with casts in low-level long API. (#104742)

iritkatriel webhook-mailer at python.org
Mon May 22 10:12:26 EDT 2023


https://github.com/python/cpython/commit/e295d8605699ad3d8ec46c8d55a5e47da05b20c6
commit: e295d8605699ad3d8ec46c8d55a5e47da05b20c6
branch: main
author: Mark Shannon <mark at hotpy.org>
committer: iritkatriel <1055913+iritkatriel at users.noreply.github.com>
date: 2023-05-22T15:12:19+01:00
summary:

GH-101291: Avoid using macros with casts in low-level long API. (#104742)

files:
M Include/cpython/longintrepr.h

diff --git a/Include/cpython/longintrepr.h b/Include/cpython/longintrepr.h
index 0f569935fff1..692c69ba76db 100644
--- a/Include/cpython/longintrepr.h
+++ b/Include/cpython/longintrepr.h
@@ -104,9 +104,10 @@ _PyLong_FromDigits(int negative, Py_ssize_t digit_count, digit *digits);
 #define _PyLong_SIGN_MASK 3
 #define _PyLong_NON_SIZE_BITS 3
 
+
 static inline int
 _PyLong_IsCompact(const PyLongObject* op) {
-    assert(PyLong_Check(op));
+    assert(PyType_HasFeature((op)->ob_base.ob_type, Py_TPFLAGS_LONG_SUBCLASS));
     return op->long_value.lv_tag < (2 << _PyLong_NON_SIZE_BITS);
 }
 
@@ -115,7 +116,7 @@ _PyLong_IsCompact(const PyLongObject* op) {
 static inline Py_ssize_t
 _PyLong_CompactValue(const PyLongObject *op)
 {
-    assert(PyLong_Check(op));
+    assert(PyType_HasFeature((op)->ob_base.ob_type, Py_TPFLAGS_LONG_SUBCLASS));
     assert(PyUnstable_Long_IsCompact(op));
     Py_ssize_t sign = 1 - (op->long_value.lv_tag & _PyLong_SIGN_MASK);
     return sign * (Py_ssize_t)op->long_value.ob_digit[0];



More information about the Python-checkins mailing list