[Python-checkins] [3.11] gh-104629: Don't skip test_clinic if _testclinic is missing (GH-104630) (#104632)

AlexWaygood webhook-mailer at python.org
Thu May 18 19:20:42 EDT 2023


https://github.com/python/cpython/commit/3d52f7e60c8217e24f6e3ba9ec3a2723c221d5f8
commit: 3d52f7e60c8217e24f6e3ba9ec3a2723c221d5f8
branch: 3.11
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: AlexWaygood <Alex.Waygood at Gmail.com>
date: 2023-05-18T23:20:35Z
summary:

[3.11] gh-104629: Don't skip test_clinic if _testclinic is missing (GH-104630) (#104632)

gh-104629: Don't skip test_clinic if _testclinic is missing (GH-104630)

Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.
(cherry picked from commit 86ee49f469b84e4b746526a00d8191d0e374a268)

Co-authored-by: Erlend E. Aasland <erlend.aasland at protonmail.com>

files:
M Lib/test/test_clinic.py

diff --git a/Lib/test/test_clinic.py b/Lib/test/test_clinic.py
index a84d24a79844..02a54bf154ee 100644
--- a/Lib/test/test_clinic.py
+++ b/Lib/test/test_clinic.py
@@ -829,9 +829,12 @@ def test_external(self):
         self.assertEqual(new_mtime_ns, old_mtime_ns)
 
 
-ac_tester = import_helper.import_module('_testclinic')
-
+try:
+    import _testclinic as ac_tester
+except ImportError:
+    ac_tester = None
 
+ at unittest.skipIf(ac_tester is None, "_testclinic is missing")
 class ClinicFunctionalTest(unittest.TestCase):
     locals().update((name, getattr(ac_tester, name))
                     for name in dir(ac_tester) if name.startswith('test_'))



More information about the Python-checkins mailing list