[Python-checkins] gh-104454: Fix refleak in AttributeError_reduce (#104455)

gpshead webhook-mailer at python.org
Sat May 13 16:45:45 EDT 2023


https://github.com/python/cpython/commit/7d2deafb73237a2175971a26cfb544974661de4b
commit: 7d2deafb73237a2175971a26cfb544974661de4b
branch: main
author: Charles Machalow <csm10495 at gmail.com>
committer: gpshead <greg at krypto.org>
date: 2023-05-13T13:45:36-07:00
summary:

gh-104454: Fix refleak in AttributeError_reduce (#104455)

* Fix the reference leak introduced by https://github.com/python/cpython/issues/103333

Co-authored-by: Kirill Podoprigora <kirill.bast9 at mail.ru>

files:
M Objects/exceptions.c

diff --git a/Objects/exceptions.c b/Objects/exceptions.c
index 59c63f4aa449..a8d4e3a696ce 100644
--- a/Objects/exceptions.c
+++ b/Objects/exceptions.c
@@ -2324,7 +2324,9 @@ AttributeError_reduce(PyAttributeErrorObject *self, PyObject *Py_UNUSED(ignored)
         return NULL;
     }
 
-    return PyTuple_Pack(3, Py_TYPE(self), self->args, state);
+    PyObject *return_value = PyTuple_Pack(3, Py_TYPE(self), self->args, state);
+    Py_DECREF(state);
+    return return_value;
 }
 
 static PyMemberDef AttributeError_members[] = {



More information about the Python-checkins mailing list