[Python-checkins] Increase stack reserve size for Windows debug builds to avoid test crashes (GH-102776)

zooba webhook-mailer at python.org
Fri Mar 17 07:38:29 EDT 2023


https://github.com/python/cpython/commit/744a41bf4963a5346f43ec8632a8becb5c0112e2
commit: 744a41bf4963a5346f43ec8632a8becb5c0112e2
branch: 3.10
author: Steve Dower <steve.dower at python.org>
committer: zooba <steve.dower at microsoft.com>
date: 2023-03-17T11:37:56Z
summary:

Increase stack reserve size for Windows debug builds to avoid test crashes (GH-102776)

files:
M PCbuild/python.vcxproj
M PCbuild/pythonw.vcxproj

diff --git a/PCbuild/python.vcxproj b/PCbuild/python.vcxproj
index b6dcf1482354..0adce0958b17 100644
--- a/PCbuild/python.vcxproj
+++ b/PCbuild/python.vcxproj
@@ -94,7 +94,8 @@
     </ClCompile>
     <Link>
       <SubSystem>Console</SubSystem>
-      <StackReserveSize>2000000</StackReserveSize>
+      <StackReserveSize Condition="$(Configuration) != 'Debug'">2000000</StackReserveSize>
+      <StackReserveSize Condition="$(Configuration) == 'Debug'">8000000</StackReserveSize>
     </Link>
   </ItemDefinitionGroup>
   <ItemGroup>
diff --git a/PCbuild/pythonw.vcxproj b/PCbuild/pythonw.vcxproj
index e7216dec3a1a..e23635e5ea94 100644
--- a/PCbuild/pythonw.vcxproj
+++ b/PCbuild/pythonw.vcxproj
@@ -89,7 +89,8 @@
   </PropertyGroup>
   <ItemDefinitionGroup>
     <Link>
-      <StackReserveSize>2000000</StackReserveSize>
+      <StackReserveSize Condition="$(Configuration) != 'Debug'">2000000</StackReserveSize>
+      <StackReserveSize Condition="$(Configuration) == 'Debug'">8000000</StackReserveSize>
     </Link>
   </ItemDefinitionGroup>
   <ItemGroup>



More information about the Python-checkins mailing list