[Python-checkins] [3.11] gh-105436: Ignore unrelated errors when checking empty env (GH-105742) (#105757)
zooba
webhook-mailer at python.org
Tue Jun 13 19:40:04 EDT 2023
https://github.com/python/cpython/commit/c2e51a9985d77e88ea2f4cfe0a53d2befc29541f
commit: c2e51a9985d77e88ea2f4cfe0a53d2befc29541f
branch: 3.11
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: zooba <steve.dower at microsoft.com>
date: 2023-06-13T23:39:56Z
summary:
[3.11] gh-105436: Ignore unrelated errors when checking empty env (GH-105742) (#105757)
gh-105436: Ignore unrelated errors when checking empty env (GH-105742)
(cherry picked from commit 4cefe3cf10f498c0927ae4fdba4880d5a64826e4)
Co-authored-by: Steve Dower <steve.dower at python.org>
files:
M Lib/test/test_subprocess.py
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 91162da4f776..8e9ad06c6eb8 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -1693,9 +1693,10 @@ def test_run_with_pathlike_path_and_arguments(self):
@unittest.skipUnless(mswindows, "Maybe test trigger a leak on Ubuntu")
def test_run_with_an_empty_env(self):
# gh-105436: fix subprocess.run(..., env={}) broken on Windows
- args = [sys.executable, "-c", 'import sys; sys.exit(57)']
- res = subprocess.run(args, env={})
- self.assertEqual(res.returncode, 57)
+ args = [sys.executable, "-c", 'pass']
+ # Ignore subprocess errors - we only care that the API doesn't
+ # raise an OSError
+ subprocess.run(args, env={})
def test_capture_output(self):
cp = self.run_python(("import sys;"
More information about the Python-checkins
mailing list