[Python-checkins] gh-74690: Further optimise `typing._ProtocolMeta.__instancecheck__` (#103280)

AlexWaygood webhook-mailer at python.org
Wed Apr 5 12:37:43 EDT 2023


https://github.com/python/cpython/commit/de182676853e8de22363e8a0641c42392c0fdaa9
commit: de182676853e8de22363e8a0641c42392c0fdaa9
branch: main
author: Alex Waygood <Alex.Waygood at Gmail.com>
committer: AlexWaygood <Alex.Waygood at Gmail.com>
date: 2023-04-05T17:37:36+01:00
summary:

gh-74690: Further optimise `typing._ProtocolMeta.__instancecheck__` (#103280)

files:
M Lib/typing.py

diff --git a/Lib/typing.py b/Lib/typing.py
index b8420f619a1d..1f1c4ffa2566 100644
--- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -2039,7 +2039,7 @@ def __instancecheck__(cls, instance):
                     val = getattr_static(instance, attr)
                 except AttributeError:
                     break
-                if callable(getattr(cls, attr, None)) and val is None:
+                if val is None and callable(getattr(cls, attr, None)):
                     break
             else:
                 return True



More information about the Python-checkins mailing list