[Python-checkins] gh-96954: Add tests for unicodedata.name/lookup (#96955)

ambv webhook-mailer at python.org
Wed Sep 21 08:52:49 EDT 2022


https://github.com/python/cpython/commit/5a32eeced2c537c13613dd4ff5b2767a37037294
commit: 5a32eeced2c537c13613dd4ff5b2767a37037294
branch: main
author: Batuhan Taskaya <isidentical at gmail.com>
committer: ambv <lukasz at langa.pl>
date: 2022-09-21T14:52:40+02:00
summary:

gh-96954: Add tests for unicodedata.name/lookup (#96955)

They were undertested, and since #96954 might involve a
rewrite of this part of the code we want to ensure that
there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz at gmx.de>

files:
M Lib/test/test_unicodedata.py

diff --git a/Lib/test/test_unicodedata.py b/Lib/test/test_unicodedata.py
index 0c31d80e103..a85bda3144b 100644
--- a/Lib/test/test_unicodedata.py
+++ b/Lib/test/test_unicodedata.py
@@ -71,7 +71,7 @@ class UnicodeFunctionsTest(UnicodeDatabaseTest):
 
     # Update this if the database changes. Make sure to do a full rebuild
     # (e.g. 'make distclean && make') to get the correct checksum.
-    expectedchecksum = '84b88a89f40aeae96852732f9dc0ee08be49780f'
+    expectedchecksum = '26ff0d31c14194b4606a5b3a81ac36df3a14e331'
 
     @requires_resource('cpu')
     def test_function_checksum(self):
@@ -91,11 +91,19 @@ def test_function_checksum(self):
                 str(self.db.mirrored(char)),
                 str(self.db.combining(char)),
                 unicodedata.east_asian_width(char),
+                self.db.name(char, ""),
             ]
             h.update(''.join(data).encode("ascii"))
         result = h.hexdigest()
         self.assertEqual(result, self.expectedchecksum)
 
+    @requires_resource('cpu')
+    def test_name_inverse_lookup(self):
+        for i in range(sys.maxunicode + 1):
+            char = chr(i)
+            if looked_name := self.db.name(char, None):
+                self.assertEqual(self.db.lookup(looked_name), char)
+
     def test_digit(self):
         self.assertEqual(self.db.digit('A', None), None)
         self.assertEqual(self.db.digit('9'), 9)



More information about the Python-checkins mailing list