[Python-checkins] gh-98629: Fixes sys._git and sys.version creation on Windows (GH-99664)

zooba webhook-mailer at python.org
Mon Nov 21 15:42:31 EST 2022


https://github.com/python/cpython/commit/49e554dbafc87245c1364ae00ad064a96f5cb995
commit: 49e554dbafc87245c1364ae00ad064a96f5cb995
branch: main
author: Steve Dower <steve.dower at python.org>
committer: zooba <steve.dower at microsoft.com>
date: 2022-11-21T20:42:18Z
summary:

gh-98629: Fixes sys._git and sys.version creation on Windows (GH-99664)

files:
A Misc/NEWS.d/next/Windows/2022-11-21-19-50-18.gh-issue-98629.tMmB_B.rst
M PCbuild/pythoncore.vcxproj

diff --git a/Misc/NEWS.d/next/Windows/2022-11-21-19-50-18.gh-issue-98629.tMmB_B.rst b/Misc/NEWS.d/next/Windows/2022-11-21-19-50-18.gh-issue-98629.tMmB_B.rst
new file mode 100644
index 000000000000..46cbf998eb20
--- /dev/null
+++ b/Misc/NEWS.d/next/Windows/2022-11-21-19-50-18.gh-issue-98629.tMmB_B.rst
@@ -0,0 +1 @@
+Fix initialization of :data:`sys.version` and ``sys._git`` on Windows
diff --git a/PCbuild/pythoncore.vcxproj b/PCbuild/pythoncore.vcxproj
index fd5c3175ce42..3c3ff406bdf0 100644
--- a/PCbuild/pythoncore.vcxproj
+++ b/PCbuild/pythoncore.vcxproj
@@ -595,7 +595,7 @@
     </PropertyGroup>
     <Message Text="Building $(GitTag):$(GitVersion) $(GitBranch)" Importance="high" />
     <ItemGroup>
-      <ClCompile Condition="$(Filename) == 'getbuildinfo'">
+      <ClCompile Condition="%(Filename) == 'getbuildinfo'">
         <PreprocessorDefinitions>GITVERSION="$(GitVersion)";GITTAG="$(GitTag)";GITBRANCH="$(GitBranch)";%(PreprocessorDefinitions)</PreprocessorDefinitions>
       </ClCompile>
     </ItemGroup>



More information about the Python-checkins mailing list