[Python-checkins] gh-95291: Use import helper to improve sqlite3 audit tests (GH-95292)

miss-islington webhook-mailer at python.org
Tue Jul 26 15:41:03 EDT 2022


https://github.com/python/cpython/commit/f118661a18f9e0cc692bfec226f38c26f5fe0558
commit: f118661a18f9e0cc692bfec226f38c26f5fe0558
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2022-07-26T12:40:59-07:00
summary:

gh-95291: Use import helper to improve sqlite3 audit tests (GH-95292)


Now the tests are correctly reported as skipped if sqlite3 is not available.
(cherry picked from commit 152eb90311fdf294510b5d077332580ba18c0ee4)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland at protonmail.com>

files:
M Lib/test/test_audit.py

diff --git a/Lib/test/test_audit.py b/Lib/test/test_audit.py
index c5ce26323b5f9..04c9d6b85539a 100644
--- a/Lib/test/test_audit.py
+++ b/Lib/test/test_audit.py
@@ -152,10 +152,7 @@ def test_http(self):
 
 
     def test_sqlite3(self):
-        try:
-            import sqlite3
-        except ImportError:
-            return
+        sqlite3 = import_helper.import_module("sqlite3")
         returncode, events, stderr = self.run_python("test_sqlite3")
         if returncode:
             self.fail(stderr)



More information about the Python-checkins mailing list