[Python-checkins] bpo-46345: Add a test case for implicit `Optional` class attribute (GH-30535)

gvanrossum webhook-mailer at python.org
Wed Jan 12 18:36:01 EST 2022


https://github.com/python/cpython/commit/1de60155d5d01be2924e72fb68dd13d4fd00acd7
commit: 1de60155d5d01be2924e72fb68dd13d4fd00acd7
branch: main
author: Nikita Sobolev <mail at sobolevn.me>
committer: gvanrossum <gvanrossum at gmail.com>
date: 2022-01-12T15:35:44-08:00
summary:

bpo-46345: Add a test case for implicit `Optional` class attribute (GH-30535)

files:
M Lib/test/test_typing.py

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index fd8237a1a8c33..c11f6f7c19224 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -3177,6 +3177,12 @@ def test_get_type_hints_classes(self):
                           'my_inner_a2': mod_generics_cache.B.A,
                           'my_outer_a': mod_generics_cache.A})
 
+    def test_get_type_hints_classes_no_implicit_optional(self):
+        class WithNoneDefault:
+            field: int = None  # most type-checkers won't be happy with it
+
+        self.assertEqual(gth(WithNoneDefault), {'field': int})
+
     def test_respect_no_type_check(self):
         @no_type_check
         class NoTpCheck:



More information about the Python-checkins mailing list