[Python-checkins] bpo-1635741: test_embed cheks that Python does not leak (GH-31555)
vstinner
webhook-mailer at python.org
Thu Feb 24 18:03:24 EST 2022
https://github.com/python/cpython/commit/c9c178fdb1af01e441a6c83f3a21a67e5dd9f17d
commit: c9c178fdb1af01e441a6c83f3a21a67e5dd9f17d
branch: main
author: Victor Stinner <vstinner at python.org>
committer: vstinner <vstinner at python.org>
date: 2022-02-25T00:03:20+01:00
summary:
bpo-1635741: test_embed cheks that Python does not leak (GH-31555)
files:
M Lib/test/test_cmd_line.py
M Lib/test/test_embed.py
diff --git a/Lib/test/test_cmd_line.py b/Lib/test/test_cmd_line.py
index 352109ed4b2ff..1521b5b50ca24 100644
--- a/Lib/test/test_cmd_line.py
+++ b/Lib/test/test_cmd_line.py
@@ -118,7 +118,7 @@ def run_python(*args):
self.assertEqual(out.rstrip(), b'{}')
self.assertEqual(err, b'')
# "-X showrefcount" shows the refcount, but only in debug builds
- rc, out, err = run_python('-X', 'showrefcount', '-c', code)
+ rc, out, err = run_python('-I', '-X', 'showrefcount', '-c', code)
self.assertEqual(out.rstrip(), b"{'showrefcount': True}")
if Py_DEBUG:
# bpo-46417: Tolerate negative reference count which can occur
diff --git a/Lib/test/test_embed.py b/Lib/test/test_embed.py
index 15c6b05916f34..e376331063d86 100644
--- a/Lib/test/test_embed.py
+++ b/Lib/test/test_embed.py
@@ -1641,6 +1641,27 @@ def test_frozenmain(self):
""").lstrip()
self.assertEqual(out, expected)
+ @unittest.skipUnless(hasattr(sys, 'gettotalrefcount'),
+ '-X showrefcount requires a Python debug build')
+ def test_no_memleak(self):
+ # bpo-1635741: Python must release all memory at exit
+ cmd = [sys.executable, "-I", "-X", "showrefcount", "-c", "pass"]
+ proc = subprocess.run(cmd,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT,
+ text=True)
+ self.assertEqual(proc.returncode, 0)
+ out = proc.stdout.rstrip()
+ match = re.match(r'^\[(-?\d+) refs, (-?\d+) blocks\]', out)
+ if not match:
+ self.fail(f"unexpected output: {out!a}")
+ refs = int(match.group(1))
+ blocks = int(match.group(2))
+ # bpo-46417: Tolerate negative reference count which can occur because
+ # of bugs in C extensions. It is only wrong if it's greater than 0.
+ self.assertLessEqual(refs, 0, out)
+ self.assertEqual(blocks, 0, out)
+
class StdPrinterTests(EmbeddingTestsMixin, unittest.TestCase):
# Test PyStdPrinter_Type which is used by _PySys_SetPreliminaryStderr():
More information about the Python-checkins
mailing list