[Python-checkins] bpo-45128: fixes `test_multiprocessing_fork` mysterious crash (GH-28387)
pablogsal
webhook-mailer at python.org
Sun Sep 19 18:50:13 EDT 2021
https://github.com/python/cpython/commit/1d42408495402b06ecae91420735aeff454be6b5
commit: 1d42408495402b06ecae91420735aeff454be6b5
branch: main
author: Nikita Sobolev <mail at sobolevn.me>
committer: pablogsal <Pablogsal at gmail.com>
date: 2021-09-19T23:50:04+01:00
summary:
bpo-45128: fixes `test_multiprocessing_fork` mysterious crash (GH-28387)
files:
A Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
M Lib/test/test_logging.py
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 211fe4bbd7bac..7a80244047d0f 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -4437,8 +4437,10 @@ def _extract_logrecord_process_name(key, logMultiprocessing, conn=None):
name = mp.current_process().name
r1 = logging.makeLogRecord({'msg': f'msg1_{key}'})
- del sys.modules['multiprocessing']
- r2 = logging.makeLogRecord({'msg': f'msg2_{key}'})
+
+ # https://bugs.python.org/issue45128
+ with support.swap_item(sys.modules, 'multiprocessing', None):
+ r2 = logging.makeLogRecord({'msg': f'msg2_{key}'})
results = {'processName' : name,
'r1.processName': r1.processName,
@@ -4487,7 +4489,6 @@ def test_multiprocessing(self):
if multiprocessing_imported:
import multiprocessing
-
def test_optional(self):
r = logging.makeLogRecord({})
NOT_NONE = self.assertIsNotNone
diff --git a/Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst b/Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
new file mode 100644
index 0000000000000..b50eb32b3faa8
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
@@ -0,0 +1,2 @@
+Fix ``test_multiprocessing_fork`` failure due to ``test_logging`` and
+``sys.modules`` manipulation.
More information about the Python-checkins
mailing list