[Python-checkins] Fix import of HTTPError (GH-22304) (GH-26048)

orsenthil webhook-mailer at python.org
Tue May 11 19:18:27 EDT 2021


https://github.com/python/cpython/commit/7d38b04b610b36af0fdcf82fba15b52c7ce44911
commit: 7d38b04b610b36af0fdcf82fba15b52c7ce44911
branch: 3.9
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: orsenthil <skumaran at gatech.edu>
date: 2021-05-11T16:18:23-07:00
summary:

Fix import of HTTPError (GH-22304) (GH-26048)

Import HTTPError from urllib.error instead of urllib.request.
(cherry picked from commit 5fedf71439187f00c661b16b80d398b74b00390e)

Co-authored-by: Sebastian Rittau <srittau at rittau.biz>

Co-authored-by: Sebastian Rittau <srittau at rittau.biz>

files:
M Lib/distutils/command/upload.py
M Lib/distutils/tests/test_upload.py

diff --git a/Lib/distutils/command/upload.py b/Lib/distutils/command/upload.py
index 95e9fda186fc8f..e0ecb655b93faf 100644
--- a/Lib/distutils/command/upload.py
+++ b/Lib/distutils/command/upload.py
@@ -9,7 +9,8 @@
 import io
 import hashlib
 from base64 import standard_b64encode
-from urllib.request import urlopen, Request, HTTPError
+from urllib.error import HTTPError
+from urllib.request import urlopen, Request
 from urllib.parse import urlparse
 from distutils.errors import DistutilsError, DistutilsOptionError
 from distutils.core import PyPIRCCommand
diff --git a/Lib/distutils/tests/test_upload.py b/Lib/distutils/tests/test_upload.py
index bca5516d2f74f6..74f0bc0a67131b 100644
--- a/Lib/distutils/tests/test_upload.py
+++ b/Lib/distutils/tests/test_upload.py
@@ -2,7 +2,7 @@
 import os
 import unittest
 import unittest.mock as mock
-from urllib.request import HTTPError
+from urllib.error import HTTPError
 
 from test.support import run_unittest
 



More information about the Python-checkins mailing list