[Python-checkins] bpo-44469: Fix tests for "async with" with bad object (GH-26817)
serhiy-storchaka
webhook-mailer at python.org
Mon Jun 21 03:22:07 EDT 2021
https://github.com/python/cpython/commit/5d2b3a0d688cf8a33db3d266c9e7049c13766a4c
commit: 5d2b3a0d688cf8a33db3d266c9e7049c13766a4c
branch: main
author: Serhiy Storchaka <storchaka at gmail.com>
committer: serhiy-storchaka <storchaka at gmail.com>
date: 2021-06-21T10:21:59+03:00
summary:
bpo-44469: Fix tests for "async with" with bad object (GH-26817)
Test for execution of the body was null. It would pass
even if the code which should be skipped was executed.
files:
M Lib/test/test_coroutines.py
diff --git a/Lib/test/test_coroutines.py b/Lib/test/test_coroutines.py
index 145adb67781701..a6a199e323c5f9 100644
--- a/Lib/test/test_coroutines.py
+++ b/Lib/test/test_coroutines.py
@@ -1205,41 +1205,47 @@ class CM:
def __aenter__(self):
pass
- body_executed = False
+ body_executed = None
async def foo():
+ nonlocal body_executed
+ body_executed = False
async with CM():
body_executed = True
with self.assertRaisesRegex(AttributeError, '__aexit__'):
run_async(foo())
- self.assertFalse(body_executed)
+ self.assertIs(body_executed, False)
def test_with_3(self):
class CM:
def __aexit__(self):
pass
- body_executed = False
+ body_executed = None
async def foo():
+ nonlocal body_executed
+ body_executed = False
async with CM():
body_executed = True
with self.assertRaisesRegex(AttributeError, '__aenter__'):
run_async(foo())
- self.assertFalse(body_executed)
+ self.assertIs(body_executed, False)
def test_with_4(self):
class CM:
pass
- body_executed = False
+ body_executed = None
async def foo():
+ nonlocal body_executed
+ body_executed = False
async with CM():
body_executed = True
with self.assertRaisesRegex(AttributeError, '__aenter__'):
run_async(foo())
- self.assertFalse(body_executed)
+ self.assertIs(body_executed, False)
def test_with_5(self):
# While this test doesn't make a lot of sense,
More information about the Python-checkins
mailing list