[Python-checkins] closes bpo-39898: Remove unused arg from append_formattedvalue. (GH-18840)

Andy Lester webhook-mailer at python.org
Sun Mar 8 12:54:06 EDT 2020


https://github.com/python/cpython/commit/28ca43b7e30e2eaa2997c3becd8b1a837484ae5c
commit: 28ca43b7e30e2eaa2997c3becd8b1a837484ae5c
branch: master
author: Andy Lester <andy at petdance.com>
committer: GitHub <noreply at github.com>
date: 2020-03-08T09:53:59-07:00
summary:

closes bpo-39898: Remove unused arg from append_formattedvalue. (GH-18840)

files:
M Python/ast_unparse.c

diff --git a/Python/ast_unparse.c b/Python/ast_unparse.c
index 1a7cd236aafa1..bd9c1396c07e5 100644
--- a/Python/ast_unparse.c
+++ b/Python/ast_unparse.c
@@ -15,7 +15,7 @@ append_ast_expr(_PyUnicodeWriter *writer, expr_ty e, int level);
 static int
 append_joinedstr(_PyUnicodeWriter *writer, expr_ty e, bool is_format_spec);
 static int
-append_formattedvalue(_PyUnicodeWriter *writer, expr_ty e, bool is_format_spec);
+append_formattedvalue(_PyUnicodeWriter *writer, expr_ty e);
 static int
 append_ast_slice(_PyUnicodeWriter *writer, slice_ty slice);
 
@@ -583,7 +583,7 @@ append_fstring_element(_PyUnicodeWriter *writer, expr_ty e, bool is_format_spec)
     case JoinedStr_kind:
         return append_joinedstr(writer, e, is_format_spec);
     case FormattedValue_kind:
-        return append_formattedvalue(writer, e, is_format_spec);
+        return append_formattedvalue(writer, e);
     default:
         PyErr_SetString(PyExc_SystemError,
                         "unknown expression kind inside f-string");
@@ -640,7 +640,7 @@ append_joinedstr(_PyUnicodeWriter *writer, expr_ty e, bool is_format_spec)
 }
 
 static int
-append_formattedvalue(_PyUnicodeWriter *writer, expr_ty e, bool is_format_spec)
+append_formattedvalue(_PyUnicodeWriter *writer, expr_ty e)
 {
     const char *conversion;
     const char *outer_brace = "{";
@@ -870,7 +870,7 @@ append_ast_expr(_PyUnicodeWriter *writer, expr_ty e, int level)
     case JoinedStr_kind:
         return append_joinedstr(writer, e, false);
     case FormattedValue_kind:
-        return append_formattedvalue(writer, e, false);
+        return append_formattedvalue(writer, e);
     /* The following exprs can be assignment targets. */
     case Attribute_kind:
         return append_ast_attribute(writer, e);



More information about the Python-checkins mailing list