[Python-checkins] bpo-40637: Do not emit warnings for disabled builtin hashes (GH-20937)

[stratakis]

https://github.com/python/cpython/commit/236a0f5cf022b59dbb6ea17a8e7a677c573d39b9
commit: 236a0f5cf022b59dbb6ea17a8e7a677c573d39b9
branch: master
author: stratakis <cstratak at redhat.com>
committer: GitHub <noreply at github.com>
date: 2020-06-17T10:26:08-07:00
summary:

bpo-40637: Do not emit warnings for disabled builtin hashes (GH-20937)



test_hashlib emits some warnings when it cannot find some hashes
as it assumes they failed to compile. Since we can disable hashes
through configure, we emit the warnings only in the case that we
did not intentionaly disable them.

Automerge-Triggered-By: @tiran

files:
M Lib/test/test_hashlib.py

diff --git a/Lib/test/test_hashlib.py b/Lib/test/test_hashlib.py
index 2f79244748e68..ba902986adb81 100644
--- a/Lib/test/test_hashlib.py
+++ b/Lib/test/test_hashlib.py
@@ -103,7 +103,7 @@ def _conditional_import_module(self, module_name):
         try:
             return importlib.import_module(module_name)
         except ModuleNotFoundError as error:
-            if self._warn_on_extension_import:
+            if self._warn_on_extension_import and module_name in builtin_hashes:
                 warnings.warn('Did a C extension fail to compile? %s' % error)
         return None