[Python-checkins] bpo-40957: Fix refleak in _Py_fopen_obj() (GH-20827)

Miss Islington (bot) webhook-mailer at python.org
Sat Jun 13 12:15:13 EDT 2020


https://github.com/python/cpython/commit/a8936fa5c09c039ad457dda8bdf733be6cc182e3
commit: a8936fa5c09c039ad457dda8bdf733be6cc182e3
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2020-06-13T09:15:05-07:00
summary:

bpo-40957: Fix refleak in _Py_fopen_obj() (GH-20827)


Signed-off-by: Christian Heimes <christian at python.org>
(cherry picked from commit 9672912e8f90374fd31b37ca0fb7cefbc6f4c555)

Co-authored-by: Christian Heimes <christian at python.org>

files:
A Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst
M Python/fileutils.c

diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst b/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst
new file mode 100644
index 0000000000000..f99c374f94aac
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst	
@@ -0,0 +1 @@
+Fix refleak in _Py_fopen_obj() when PySys_Audit() fails
diff --git a/Python/fileutils.c b/Python/fileutils.c
index e79e732d1f55b..1021ddb58853e 100644
--- a/Python/fileutils.c
+++ b/Python/fileutils.c
@@ -1461,6 +1461,7 @@ _Py_fopen_obj(PyObject *path, const char *mode)
     path_bytes = PyBytes_AS_STRING(bytes);
 
     if (PySys_Audit("open", "Osi", path, mode, 0) < 0) {
+        Py_DECREF(bytes);
         return NULL;
     }
 



More information about the Python-checkins mailing list