[Python-checkins] bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue] (GH-13950)
Miss Islington (bot)
webhook-mailer at python.org
Tue Sep 10 08:50:18 EDT 2019
https://github.com/python/cpython/commit/55daf1a56163e0673654712bb92ce47a9b6f7be3
commit: 55daf1a56163e0673654712bb92ce47a9b6f7be3
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-09-10T05:50:14-07:00
summary:
bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue] (GH-13950)
This PR deprecate explicit loop parameters in all public asyncio APIs
This issues is split to be easier to review.
fourth step: queue.py
https://bugs.python.org/issue36373
(cherry picked from commit 9008be303a89bfab8c3314c6a42330b5523adc8b)
Co-authored-by: Emmanuel Arias <emmanuelarias30 at gmail.com>
files:
M Doc/library/asyncio-queue.rst
M Lib/asyncio/queues.py
diff --git a/Doc/library/asyncio-queue.rst b/Doc/library/asyncio-queue.rst
index 7be1023c80cc..e7775da54f58 100644
--- a/Doc/library/asyncio-queue.rst
+++ b/Doc/library/asyncio-queue.rst
@@ -32,6 +32,10 @@ Queue
the queue is always known and can be returned by calling the
:meth:`qsize` method.
+ .. deprecated-removed:: 3.8 3.10
+ The *loop* parameter.
+
+
This class is :ref:`not thread safe <asyncio-multithreading>`.
.. attribute:: maxsize
diff --git a/Lib/asyncio/queues.py b/Lib/asyncio/queues.py
index 2a8d3e760441..c96b4a0c1ba3 100644
--- a/Lib/asyncio/queues.py
+++ b/Lib/asyncio/queues.py
@@ -2,6 +2,7 @@
import collections
import heapq
+import warnings
from . import events
from . import locks
@@ -34,6 +35,9 @@ def __init__(self, maxsize=0, *, loop=None):
self._loop = events.get_event_loop()
else:
self._loop = loop
+ warnings.warn("The loop argument is deprecated since Python 3.8, "
+ "and scheduled for removal in Python 3.10.",
+ DeprecationWarning, stacklevel=2)
self._maxsize = maxsize
# Futures.
More information about the Python-checkins
mailing list