[Python-checkins] IDLE - Capitalize search dialogs' 'Close' button label. (#13691)
Terry Jan Reedy
webhook-mailer at python.org
Fri May 31 04:26:50 EDT 2019
https://github.com/python/cpython/commit/ba0430211f5101c9d748d72b03926ca79c5252a8
commit: ba0430211f5101c9d748d72b03926ca79c5252a8
branch: master
author: Terry Jan Reedy <tjreedy at udel.edu>
committer: GitHub <noreply at github.com>
date: 2019-05-31T04:26:35-04:00
summary:
IDLE - Capitalize search dialogs' 'Close' button label. (#13691)
It seems to be the only widget label not capitalized.
files:
M Lib/idlelib/idle_test/test_searchbase.py
M Lib/idlelib/searchbase.py
diff --git a/Lib/idlelib/idle_test/test_searchbase.py b/Lib/idlelib/idle_test/test_searchbase.py
index 09a7fff51de1..6dd4d7933737 100644
--- a/Lib/idlelib/idle_test/test_searchbase.py
+++ b/Lib/idlelib/idle_test/test_searchbase.py
@@ -32,6 +32,7 @@ def setUpClass(cls):
@classmethod
def tearDownClass(cls):
+ cls.root.update_idletasks()
cls.root.destroy()
del cls.root
@@ -149,7 +150,7 @@ def test_create_command_buttons(self):
# Look for close button command in buttonframe
closebuttoncommand = ''
for child in self.dialog.buttonframe.winfo_children():
- if child['text'] == 'close':
+ if child['text'] == 'Close':
closebuttoncommand = child['command']
self.assertIn('close', closebuttoncommand)
diff --git a/Lib/idlelib/searchbase.py b/Lib/idlelib/searchbase.py
index f0e3d6f14ba4..74ba8538512b 100644
--- a/Lib/idlelib/searchbase.py
+++ b/Lib/idlelib/searchbase.py
@@ -172,7 +172,7 @@ def create_command_buttons(self):
f = self.buttonframe = Frame(self.top)
f.grid(row=0,column=2,padx=2,pady=2,ipadx=2,ipady=2)
- b = self.make_button("close", self.close)
+ b = self.make_button("Close", self.close)
b.lower()
More information about the Python-checkins
mailing list