[Python-checkins] bpo-37233: use _PY_FASTCALL_SMALL_STACK in method_vectorcall (GH-13974)
Inada Naoki
webhook-mailer at python.org
Tue Jun 18 04:56:58 EDT 2019
https://github.com/python/cpython/commit/988e6aa322fb61651812fa5a61ec73316c71b041
commit: 988e6aa322fb61651812fa5a61ec73316c71b041
branch: master
author: Jeroen Demeyer <J.Demeyer at UGent.be>
committer: Inada Naoki <songofacandy at gmail.com>
date: 2019-06-18T17:56:53+09:00
summary:
bpo-37233: use _PY_FASTCALL_SMALL_STACK in method_vectorcall (GH-13974)
files:
M Objects/classobject.c
diff --git a/Objects/classobject.c b/Objects/classobject.c
index ec4d2b9910a2..3062890f53e6 100644
--- a/Objects/classobject.c
+++ b/Objects/classobject.c
@@ -64,10 +64,16 @@ method_vectorcall(PyObject *method, PyObject *const *args,
Py_ssize_t nkwargs = (kwnames == NULL) ? 0 : PyTuple_GET_SIZE(kwnames);
PyObject **newargs;
Py_ssize_t totalargs = nargs + nkwargs;
- newargs = PyMem_Malloc((totalargs+1) * sizeof(PyObject *));
- if (newargs == NULL) {
- PyErr_NoMemory();
- return NULL;
+ PyObject *newargs_stack[_PY_FASTCALL_SMALL_STACK];
+ if (totalargs <= (Py_ssize_t)Py_ARRAY_LENGTH(newargs_stack) - 1) {
+ newargs = newargs_stack;
+ }
+ else {
+ newargs = PyMem_Malloc((totalargs+1) * sizeof(PyObject *));
+ if (newargs == NULL) {
+ PyErr_NoMemory();
+ return NULL;
+ }
}
/* use borrowed references */
newargs[0] = self;
@@ -77,7 +83,9 @@ method_vectorcall(PyObject *method, PyObject *const *args,
memcpy(newargs + 1, args, totalargs * sizeof(PyObject *));
}
result = _PyObject_Vectorcall(func, newargs, nargs+1, kwnames);
- PyMem_Free(newargs);
+ if (newargs != newargs_stack) {
+ PyMem_Free(newargs);
+ }
}
return result;
}
More information about the Python-checkins
mailing list