[Python-checkins] Minor improvement to code clarity (GH-9036)
Raymond Hettinger
webhook-mailer at python.org
Sun Sep 2 16:34:26 EDT 2018
https://github.com/python/cpython/commit/f3267144269b873bcb87a9fcafe94b37be1bcfdc
commit: f3267144269b873bcb87a9fcafe94b37be1bcfdc
branch: master
author: Raymond Hettinger <rhettinger at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-09-02T13:34:21-07:00
summary:
Minor improvement to code clarity (GH-9036)
Make it clear that the n==0 case is included. Otherwise, you have to know that max==0.0 whenever n==0.
files:
M Modules/mathmodule.c
diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
index 8015a95d2aa7..06a969cebacb 100644
--- a/Modules/mathmodule.c
+++ b/Modules/mathmodule.c
@@ -2074,7 +2074,7 @@ vector_norm(Py_ssize_t n, double *vec, double max, int found_nan)
if (found_nan) {
return Py_NAN;
}
- if (max == 0.0 || n == 1) {
+ if (max == 0.0 || n <= 1) {
return max;
}
for (i=0 ; i < n ; i++) {
More information about the Python-checkins
mailing list