[Python-checkins] bpo-34783: Disable test_nonexisting_script for macOS framework builds (GH-9831)

Ned Deily webhook-mailer at python.org
Fri Oct 12 23:54:24 EDT 2018


https://github.com/python/cpython/commit/f6c29a65e2a6da5c0014c868cf963c975b74e72b
commit: f6c29a65e2a6da5c0014c868cf963c975b74e72b
branch: master
author: Ned Deily <nad at python.org>
committer: GitHub <noreply at github.com>
date: 2018-10-12T23:54:20-04:00
summary:

bpo-34783:  Disable test_nonexisting_script for macOS framework builds (GH-9831)

With macOS framework builds, test case test_nonexisting_script in
test_nonexisting_script fails because the test case assumes that
the file name in sys.executable will appear in the error message.
For macOS framework builds, sys.executable is the file name of the
stub launcher and its file name bears no relationship to the file
name of the actual python executable.  For now, skip the test in
this case.

files:
M Lib/test/test_cmd_line_script.py

diff --git a/Lib/test/test_cmd_line_script.py b/Lib/test/test_cmd_line_script.py
index 2595ca98c7ad..4f5af3754418 100644
--- a/Lib/test/test_cmd_line_script.py
+++ b/Lib/test/test_cmd_line_script.py
@@ -630,9 +630,13 @@ def test_consistent_sys_path_for_module_execution(self):
             traceback_lines = stderr.decode().splitlines()
             self.assertIn("No module named script_pkg", traceback_lines[-1])
 
+    @unittest.skipIf(sys.platform == 'darwin' and sys._framework,
+                        "test not valid for macOS framework builds")
     def test_nonexisting_script(self):
         # bpo-34783: "./python script.py" must not crash
         # if the script file doesn't exist.
+        # (Skip test for macOS framework builds because sys.excutable name
+        #  is not the actual Python executable file name.
         script = 'nonexistingscript.py'
         self.assertFalse(os.path.exists(script))
         # Only test the base name, since the error message can use



More information about the Python-checkins mailing list