[Python-checkins] bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808)

Serhiy Storchaka webhook-mailer at python.org
Fri Nov 30 02:40:21 EST 2018


https://github.com/python/cpython/commit/a2e3585e79c93b2372dbad46a744e28fcc6dad6d
commit: a2e3585e79c93b2372dbad46a744e28fcc6dad6d
branch: master
author: Zackery Spytz <zspytz at gmail.com>
committer: Serhiy Storchaka <storchaka at gmail.com>
date: 2018-11-30T09:40:16+02:00
summary:

bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808)

files:
M Modules/nismodule.c

diff --git a/Modules/nismodule.c b/Modules/nismodule.c
index bc6796c278ca..a24978e06867 100644
--- a/Modules/nismodule.c
+++ b/Modules/nismodule.c
@@ -412,6 +412,7 @@ nis_maps (PyObject *self, PyObject *args, PyObject *kwdict)
         PyObject *str = PyUnicode_FromString(maps->map);
         if (!str || PyList_Append(list, str) < 0)
         {
+            Py_XDECREF(str);
             Py_DECREF(list);
             list = NULL;
             break;



More information about the Python-checkins mailing list