[Python-checkins] bpo-33802: Do not interpolate in ConfigParser while reading defaults (GH-7524)
Łukasz Langa
webhook-mailer at python.org
Fri Jun 8 07:02:52 EDT 2018
https://github.com/python/cpython/commit/214f18e49feb6a9d6c05aa09a4bb304905e81334
commit: 214f18e49feb6a9d6c05aa09a4bb304905e81334
branch: master
author: Łukasz Langa <lukasz at langa.pl>
committer: GitHub <noreply at github.com>
date: 2018-06-08T04:02:48-07:00
summary:
bpo-33802: Do not interpolate in ConfigParser while reading defaults (GH-7524)
This solves a regression in logging config due to changes in BPO-23835.
files:
M Lib/configparser.py
M Lib/test/test_logging.py
diff --git a/Lib/configparser.py b/Lib/configparser.py
index c88605feff78..ea788aec5100 100644
--- a/Lib/configparser.py
+++ b/Lib/configparser.py
@@ -1208,8 +1208,16 @@ def add_section(self, section):
def _read_defaults(self, defaults):
"""Reads the defaults passed in the initializer, implicitly converting
- values to strings like the rest of the API."""
- self.read_dict({self.default_section: defaults})
+ values to strings like the rest of the API.
+
+ Does not perform interpolation for backwards compatibility.
+ """
+ try:
+ hold_interpolation = self._interpolation
+ self._interpolation = Interpolation()
+ self.read_dict({self.default_section: defaults})
+ finally:
+ self._interpolation = hold_interpolation
class SafeConfigParser(ConfigParser):
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 5098866237c8..ba70b117d1e6 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -1451,6 +1451,49 @@ def test_logger_disabling(self):
self.apply_config(self.disable_test, disable_existing_loggers=False)
self.assertFalse(logger.disabled)
+ def test_defaults_do_no_interpolation(self):
+ """bpo-33802 defaults should not get interpolated"""
+ ini = textwrap.dedent("""
+ [formatters]
+ keys=default
+
+ [formatter_default]
+
+ [handlers]
+ keys=console
+
+ [handler_console]
+ class=logging.StreamHandler
+ args=tuple()
+
+ [loggers]
+ keys=root
+
+ [logger_root]
+ formatter=default
+ handlers=console
+ """).strip()
+ fd, fn = tempfile.mkstemp(prefix='test_logging_', suffix='.ini')
+ try:
+ os.write(fd, ini.encode('ascii'))
+ os.close(fd)
+ logging.config.fileConfig(
+ fn,
+ defaults=dict(
+ version=1,
+ disable_existing_loggers=False,
+ formatters={
+ "generic": {
+ "format": "%(asctime)s [%(process)d] [%(levelname)s] %(message)s",
+ "datefmt": "[%Y-%m-%d %H:%M:%S %z]",
+ "class": "logging.Formatter"
+ },
+ },
+ )
+ )
+ finally:
+ os.unlink(fn)
+
class SocketHandlerTest(BaseTest):
More information about the Python-checkins
mailing list