[Python-checkins] Remove creation of a list for row_cast_map in pysqlite_cursor_init() (GH-8494)
Berker Peksag
webhook-mailer at python.org
Mon Jul 30 17:11:54 EDT 2018
https://github.com/python/cpython/commit/b229b072a9e972905883da5e9eed1f22ab81c7b7
commit: b229b072a9e972905883da5e9eed1f22ab81c7b7
branch: master
author: Sergey Fedoseev <fedoseev.sergey at gmail.com>
committer: Berker Peksag <berker.peksag at gmail.com>
date: 2018-07-31T00:11:50+03:00
summary:
Remove creation of a list for row_cast_map in pysqlite_cursor_init() (GH-8494)
This list is never used: if detect_types is on, this list will be
replaced with another one before row_cast_map is used, if
detect_types is off, row_cast_map is not used at all.
files:
M Modules/_sqlite/cursor.c
diff --git a/Modules/_sqlite/cursor.c b/Modules/_sqlite/cursor.c
index 70b304f4e3fb..c62ad5d64eec 100644
--- a/Modules/_sqlite/cursor.c
+++ b/Modules/_sqlite/cursor.c
@@ -42,11 +42,7 @@ static int pysqlite_cursor_init(pysqlite_Cursor* self, PyObject* args, PyObject*
Py_XSETREF(self->connection, connection);
Py_CLEAR(self->statement);
Py_CLEAR(self->next_row);
-
- Py_XSETREF(self->row_cast_map, PyList_New(0));
- if (!self->row_cast_map) {
- return -1;
- }
+ Py_CLEAR(self->row_cast_map);
Py_INCREF(Py_None);
Py_XSETREF(self->description, Py_None);
@@ -253,6 +249,7 @@ PyObject* _pysqlite_fetch_one_row(pysqlite_Cursor* self)
for (i = 0; i < numcols; i++) {
if (self->connection->detect_types) {
+ assert(self->row_cast_map != NULL);
converter = PyList_GetItem(self->row_cast_map, i);
if (!converter) {
converter = Py_None;
More information about the Python-checkins
mailing list