[Python-checkins] bpo-35591: IDLE Find Selection now works when selection not found (GH-11339)

Terry Jan Reedy webhook-mailer at python.org
Fri Dec 28 02:41:44 EST 2018


https://github.com/python/cpython/commit/c465682718f15cd3deb6b37db5fb607718ac64ed
commit: c465682718f15cd3deb6b37db5fb607718ac64ed
branch: master
author: Terry Jan Reedy <tjreedy at udel.edu>
committer: GitHub <noreply at github.com>
date: 2018-12-28T02:41:35-05:00
summary:

bpo-35591: IDLE Find Selection now works when selection not found (GH-11339)

files:
A Misc/NEWS.d/next/IDLE/2018-12-28-01-19-20.bpo-35591.SFpDj2.rst
M Lib/idlelib/searchbase.py

diff --git a/Lib/idlelib/searchbase.py b/Lib/idlelib/searchbase.py
index 9b03ff64c1e1..348db660e3e9 100644
--- a/Lib/idlelib/searchbase.py
+++ b/Lib/idlelib/searchbase.py
@@ -42,6 +42,7 @@ def __init__(self, root, engine):
         icon (of dialog): ditto, use unclear if cannot minimize dialog.
         '''
         self.root = root
+        self.bell = root.bell
         self.engine = engine
         self.top = None
 
@@ -80,7 +81,6 @@ def create_widgets(self):
         top.wm_title(self.title)
         top.wm_iconname(self.icon)
         self.top = top
-        self.bell = top.bell
 
         self.row = 0
         self.top.grid_columnconfigure(0, pad=2, weight=0)
diff --git a/Misc/NEWS.d/next/IDLE/2018-12-28-01-19-20.bpo-35591.SFpDj2.rst b/Misc/NEWS.d/next/IDLE/2018-12-28-01-19-20.bpo-35591.SFpDj2.rst
new file mode 100644
index 000000000000..33f67a4cfe6f
--- /dev/null
+++ b/Misc/NEWS.d/next/IDLE/2018-12-28-01-19-20.bpo-35591.SFpDj2.rst
@@ -0,0 +1 @@
+Find Selection now works when selection not found.



More information about the Python-checkins mailing list