[Python-checkins] [3.6] bpo-30640: Fix undefined behavior in _PyFunction_FastCallDict() and PyEval_EvalCodeEx() (GH-2919) (#2964)

Victor Stinner webhook-mailer at python.org
Thu Sep 7 21:17:41 EDT 2017


https://github.com/python/cpython/commit/f032e9237aa7d43d21e0b04d685c36bddf7078c1
commit: f032e9237aa7d43d21e0b04d685c36bddf7078c1
branch: 3.6
author: Zackery Spytz <Osmunda46 at gmail.com>
committer: Victor Stinner <victor.stinner at gmail.com>
date: 2017-09-08T03:17:38+02:00
summary:

[3.6] bpo-30640: Fix undefined behavior in _PyFunction_FastCallDict() and PyEval_EvalCodeEx() (GH-2919) (#2964)

k + 1 was calculated with k = NULL..
(cherry picked from commit c6ea8974e2d939223bfd6d64ee13ec89c090d2e0)

files:
M Python/ceval.c

diff --git a/Python/ceval.c b/Python/ceval.c
index 8eb78bf4d46..4aa3250cd0b 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -4171,7 +4171,8 @@ PyEval_EvalCodeEx(PyObject *_co, PyObject *globals, PyObject *locals,
 {
     return _PyEval_EvalCodeWithName(_co, globals, locals,
                                     args, argcount,
-                                    kws, kws + 1, kwcount, 2,
+                                    kws, kws != NULL ? kws + 1 : NULL,
+                                    kwcount, 2,
                                     defs, defcount,
                                     kwdefs, closure,
                                     NULL, NULL);
@@ -5053,7 +5054,7 @@ _PyFunction_FastCallDict(PyObject *func, PyObject **args, Py_ssize_t nargs,
 
     result = _PyEval_EvalCodeWithName((PyObject*)co, globals, (PyObject *)NULL,
                                       args, nargs,
-                                      k, k + 1, nk, 2,
+                                      k, k != NULL ? k + 1 : NULL, nk, 2,
                                       d, nd, kwdefs,
                                       closure, name, qualname);
     Py_XDECREF(kwtuple);



More information about the Python-checkins mailing list