[Python-checkins] weaken pthread_getcpuclockid test (more bpo-31596) (#3904)

Benjamin Peterson webhook-mailer at python.org
Fri Oct 6 01:50:45 EDT 2017


https://github.com/python/cpython/commit/86566702f311f8e90600e85350f6b6769a384ea5
commit: 86566702f311f8e90600e85350f6b6769a384ea5
branch: master
author: Benjamin Peterson <benjamin at python.org>
committer: GitHub <noreply at github.com>
date: 2017-10-05T22:50:42-07:00
summary:

weaken pthread_getcpuclockid test (more bpo-31596) (#3904)

There just isn't much we can assert in a portable way.

files:
M Lib/test/test_time.py

diff --git a/Lib/test/test_time.py b/Lib/test/test_time.py
index 1456748ed8e..c92e66bf49a 100644
--- a/Lib/test/test_time.py
+++ b/Lib/test/test_time.py
@@ -85,20 +85,13 @@ def test_clock_monotonic(self):
                          'need time.pthread_getcpuclockid()')
     @unittest.skipUnless(hasattr(time, 'clock_gettime'),
                          'need time.clock_gettime()')
-    @unittest.skipUnless(hasattr(time, 'CLOCK_THREAD_CPUTIME_ID'),
-                         'need time.CLOCK_THREAD_CPUTIME_ID')
     def test_pthread_getcpuclockid(self):
         clk_id = time.pthread_getcpuclockid(threading.get_ident())
         self.assertTrue(type(clk_id) is int)
         self.assertNotEqual(clk_id, time.CLOCK_THREAD_CPUTIME_ID)
-        # This should suffice to show that both calls are measuring the same clock.
         t1 = time.clock_gettime(clk_id)
-        t2 = time.clock_gettime(time.CLOCK_THREAD_CPUTIME_ID)
-        t3 = time.clock_gettime(clk_id)
-        t4 = time.clock_gettime(time.CLOCK_THREAD_CPUTIME_ID)
+        t2 = time.clock_gettime(clk_id)
         self.assertLessEqual(t1, t2)
-        self.assertLessEqual(t2, t3)
-        self.assertLessEqual(t3, t4)
 
     @unittest.skipUnless(hasattr(time, 'clock_getres'),
                          'need time.clock_getres()')



More information about the Python-checkins mailing list