[Python-checkins] mark fatal_error as noreturn (#4563)

[Benjamin Peterson]

https://github.com/python/cpython/commit/cef88b9c15cf387cf6a39a387a6868883409df4f
commit: cef88b9c15cf387cf6a39a387a6868883409df4f
branch: master
author: Benjamin Peterson <benjamin at python.org>
committer: GitHub <noreply at github.com>
date: 2017-11-25T13:02:55-08:00
summary:

mark fatal_error as noreturn (#4563)

clang can't figure out that fatal_error is noreturn itself and emits warnings:

../cpython/Python/pylifecycle.c:2116:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^
../cpython/Python/pylifecycle.c:2125:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^

files:
M Python/pylifecycle.c

diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index 868ac8450d4..b89cbc88d4b 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -2048,7 +2048,7 @@ fatal_output_debug(const char *msg)
 }
 #endif
 
-static void
+static void _Py_NO_RETURN
 fatal_error(const char *prefix, const char *msg, int status)
 {
     const int fd = fileno(stderr);