[Python-checkins] bpo-31960: Fix asyncio.Future documentation for thread (un)safety. (#4319)
Antoine Pitrou
webhook-mailer at python.org
Tue Nov 7 11:03:34 EST 2017
https://github.com/python/cpython/commit/22b1128559bdeb96907da5840960691bb050d11a
commit: 22b1128559bdeb96907da5840960691bb050d11a
branch: master
author: Antoine Pitrou <pitrou at free.fr>
committer: GitHub <noreply at github.com>
date: 2017-11-07T17:03:28+01:00
summary:
bpo-31960: Fix asyncio.Future documentation for thread (un)safety. (#4319)
files:
M Doc/library/asyncio-task.rst
M Lib/asyncio/futures.py
diff --git a/Doc/library/asyncio-task.rst b/Doc/library/asyncio-task.rst
index fbb31b866ae..ff35b0add9d 100644
--- a/Doc/library/asyncio-task.rst
+++ b/Doc/library/asyncio-task.rst
@@ -216,7 +216,7 @@ Future
raise an exception when the future isn't done yet.
- Callbacks registered with :meth:`add_done_callback` are always called
- via the event loop's :meth:`~AbstractEventLoop.call_soon_threadsafe`.
+ via the event loop's :meth:`~AbstractEventLoop.call_soon`.
- This class is not compatible with the :func:`~concurrent.futures.wait` and
:func:`~concurrent.futures.as_completed` functions in the
diff --git a/Lib/asyncio/futures.py b/Lib/asyncio/futures.py
index 215f72d1910..3dc9c500b33 100644
--- a/Lib/asyncio/futures.py
+++ b/Lib/asyncio/futures.py
@@ -32,11 +32,13 @@ class Future:
Differences:
+ - This class is not thread-safe.
+
- result() and exception() do not take a timeout argument and
raise an exception when the future isn't done yet.
- Callbacks registered with add_done_callback() are always called
- via the event loop's call_soon_threadsafe().
+ via the event loop's call_soon().
- This class is not compatible with the wait() and as_completed()
methods in the concurrent.futures package.
More information about the Python-checkins
mailing list