[Python-checkins] [2.7] bpo-31044: Skip test_posix.test_makedev() on FreeBSD (#2915) (#2918)

Victor Stinner webhook-mailer at python.org
Thu Jul 27 12:44:46 EDT 2017


https://github.com/python/cpython/commit/c2f7fb61511456c62877592988b31714cb8ba266
commit: c2f7fb61511456c62877592988b31714cb8ba266
branch: 2.7
author: Victor Stinner <victor.stinner at gmail.com>
committer: GitHub <noreply at github.com>
date: 2017-07-27T18:44:43+02:00
summary:

[2.7] bpo-31044: Skip test_posix.test_makedev() on FreeBSD (#2915) (#2918)

* bpo-31044: Skip test_posix.test_makedev() on FreeBSD (#2915)

There is a bug in FreeBSD CURRENT with 64-bit dev_t. Skip the test if
dev_t is larger than 32-bit, until the bug is fixed in FreeBSD
CURRENT.
(cherry picked from commit 12953ffe12ac781332b384c36b25d12216b1db62)

* Fix syntax for Python 2.7

files:
M Lib/test/test_posix.py

diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
index f1626b717fc..bce4e21e992 100644
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -287,6 +287,10 @@ def test_makedev(self):
         self.assertRaises(TypeError, posix.minor)
         self.assertRaises((ValueError, OverflowError), posix.minor, -1)
 
+        if sys.platform.startswith('freebsd') and dev >= 0x100000000:
+            self.skipTest("bpo-31044: on FreeBSD CURRENT, minor() truncates "
+                          "64-bit dev to 32-bit")
+
         self.assertEqual(posix.makedev(major, minor), dev)
         self.assertEqual(posix.makedev(int(major), int(minor)), dev)
         self.assertEqual(posix.makedev(long(major), long(minor)), dev)



More information about the Python-checkins mailing list