[Python-checkins] cpython (3.5): Issue #29094: Offsets in a ZIP file created with extern file object and modes
serhiy.storchaka
python-checkins at python.org
Sun Jan 1 12:08:27 EST 2017
https://hg.python.org/cpython/rev/f5aa1c9c2b7e
changeset: 105918:f5aa1c9c2b7e
branch: 3.5
parent: 105914:bb64ae455490
user: Serhiy Storchaka <storchaka at gmail.com>
date: Sun Jan 01 19:00:30 2017 +0200
summary:
Issue #29094: Offsets in a ZIP file created with extern file object and modes
"w" and "x" now are relative to the start of the file.
files:
Lib/zipfile.py | 5 +++--
Misc/NEWS | 3 +++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Lib/zipfile.py b/Lib/zipfile.py
--- a/Lib/zipfile.py
+++ b/Lib/zipfile.py
@@ -1028,11 +1028,12 @@
# set the modified flag so central directory gets written
# even if no files are added to the archive
self._didModify = True
+ self._start_disk = 0
try:
- self.start_dir = self._start_disk = self.fp.tell()
+ self.start_dir = self.fp.tell()
except (AttributeError, OSError):
self.fp = _Tellable(self.fp)
- self.start_dir = self._start_disk = 0
+ self.start_dir = 0
self._seekable = False
else:
# Some file-like objects can provide tell() but not seek()
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -140,6 +140,9 @@
Library
-------
+- Issue #29094: Offsets in a ZIP file created with extern file object and modes
+ "w" and "x" now are relative to the start of the file.
+
- Issue #13051: Fixed recursion errors in large or resized
curses.textpad.Textbox. Based on patch by Tycho Andersen.
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list