[Python-checkins] cpython (3.5): Issue #25659: Change assert to TypeError in from_buffer/_copy()
martin.panter
python-checkins at python.org
Sun Nov 20 18:24:09 EST 2016
https://hg.python.org/cpython/rev/5f061870d49c
changeset: 105240:5f061870d49c
branch: 3.5
user: Martin Panter <vadmium+py at gmail.com>
date: Sun Nov 20 07:58:35 2016 +0000
summary:
Issue #25659: Change assert to TypeError in from_buffer/_copy()
Based on suggestion by Eryk Sun.
files:
Lib/ctypes/test/test_frombuffer.py | 8 ++++++++
Misc/NEWS | 3 +++
Modules/_ctypes/_ctypes.c | 14 ++++++++++----
3 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/Lib/ctypes/test/test_frombuffer.py b/Lib/ctypes/test/test_frombuffer.py
--- a/Lib/ctypes/test/test_frombuffer.py
+++ b/Lib/ctypes/test/test_frombuffer.py
@@ -120,5 +120,13 @@
with self.assertRaises(ValueError):
(c_int * 1).from_buffer_copy(a, 16 * sizeof(c_int))
+ def test_abstract(self):
+ self.assertRaises(TypeError, Array.from_buffer, bytearray(10))
+ self.assertRaises(TypeError, Structure.from_buffer, bytearray(10))
+ self.assertRaises(TypeError, Union.from_buffer, bytearray(10))
+ self.assertRaises(TypeError, Array.from_buffer_copy, b"123")
+ self.assertRaises(TypeError, Structure.from_buffer_copy, b"123")
+ self.assertRaises(TypeError, Union.from_buffer_copy, b"123")
+
if __name__ == '__main__':
unittest.main()
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -121,6 +121,9 @@
Library
-------
+- Issue #25659: In ctypes, prevent a crash calling the from_buffer() and
+ from_buffer_copy() methods on abstract classes like Array.
+
- Issue #28732: Fix crash in os.spawnv() with no elements in args
- Issue #28485: Always raise ValueError for negative
diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
--- a/Modules/_ctypes/_ctypes.c
+++ b/Modules/_ctypes/_ctypes.c
@@ -469,7 +469,10 @@
Py_ssize_t offset = 0;
StgDictObject *dict = PyType_stgdict(type);
- assert (dict);
+ if (!dict) {
+ PyErr_SetString(PyExc_TypeError, "abstract class");
+ return NULL;
+ }
if (!PyArg_ParseTuple(args, "O|n:from_buffer", &obj, &offset))
return NULL;
@@ -537,9 +540,12 @@
Py_ssize_t offset = 0;
PyObject *result;
StgDictObject *dict = PyType_stgdict(type);
- assert (dict);
-
- if (!PyArg_ParseTuple(args, "y*|n:from_buffer", &buffer, &offset))
+ if (!dict) {
+ PyErr_SetString(PyExc_TypeError, "abstract class");
+ return NULL;
+ }
+
+ if (!PyArg_ParseTuple(args, "y*|n:from_buffer_copy", &buffer, &offset))
return NULL;
if (offset < 0) {
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list