[Python-checkins] cpython (3.6): Issue #28605: Fix the help and What's New entry for --with-optimizations.

brett.cannon python-checkins at python.org
Thu Nov 3 19:21:16 EDT 2016


https://hg.python.org/cpython/rev/1f750fff788e
changeset:   104899:1f750fff788e
branch:      3.6
parent:      104897:5af19a28c76e
user:        Brett Cannon <brett at python.org>
date:        Thu Nov 03 16:20:00 2016 -0700
summary:
  Issue #28605: Fix the help and What's New entry for --with-optimizations.

files:
  Doc/whatsnew/3.6.rst |  2 +-
  configure            |  6 +++---
  configure.ac         |  4 ++--
  3 files changed, 6 insertions(+), 6 deletions(-)


diff --git a/Doc/whatsnew/3.6.rst b/Doc/whatsnew/3.6.rst
--- a/Doc/whatsnew/3.6.rst
+++ b/Doc/whatsnew/3.6.rst
@@ -1176,7 +1176,7 @@
   with only about 16 tests failures. See the Android meta-issue :issue:`26865`.
 
 * The ``--with-optimizations`` configure flag has been added. Turning it on
-  will activate LTO and PGO build support (when available).
+  will activate expensive optimizations like PGO.
   (Original patch by Alecsandru Patrascu of Intel in :issue:`26539`.)
 
 * New :c:func:`Py_FinalizeEx` API which indicates if flushing buffered data
diff --git a/configure b/configure
--- a/configure
+++ b/configure
@@ -1499,8 +1499,8 @@
                           compiler
   --with-suffix=.exe      set executable suffix
   --with-pydebug          build with Py_DEBUG defined
-  --with-optimizations    Enable expensive optimizations (PGO, maybe LTO,
-                          etc). Disabled by default.
+  --with-optimizations    Enable expensive optimizations (PGO, etc). Disabled
+                          by default.
   --with-lto              Enable Link Time Optimization in PGO builds.
                           Disabled by default.
   --with-hash-algorithm=[fnv|siphash24]
@@ -6548,7 +6548,7 @@
 if test "$Py_OPT" = 'true' ; then
   # Intentionally not forcing Py_LTO='true' here.  Too many toolchains do not
   # compile working code using it and both test_distutils and test_gdb are
-  # broken when you do managed to get a toolchain that works with it.  People
+  # broken when you do manage to get a toolchain that works with it.  People
   # who want LTO need to use --with-lto themselves.
   DEF_MAKE_ALL_RULE="profile-opt"
   REQUIRE_PGO="yes"
diff --git a/configure.ac b/configure.ac
--- a/configure.ac
+++ b/configure.ac
@@ -1282,7 +1282,7 @@
 AC_SUBST(DEF_MAKE_RULE)
 Py_OPT='false'
 AC_MSG_CHECKING(for --with-optimizations)
-AC_ARG_WITH(optimizations, AS_HELP_STRING([--with-optimizations], [Enable expensive optimizations (PGO, maybe LTO, etc).  Disabled by default.]),
+AC_ARG_WITH(optimizations, AS_HELP_STRING([--with-optimizations], [Enable expensive optimizations (PGO, etc).  Disabled by default.]),
 [
 if test "$withval" != no
 then
@@ -1296,7 +1296,7 @@
 if test "$Py_OPT" = 'true' ; then
   # Intentionally not forcing Py_LTO='true' here.  Too many toolchains do not
   # compile working code using it and both test_distutils and test_gdb are
-  # broken when you do managed to get a toolchain that works with it.  People
+  # broken when you do manage to get a toolchain that works with it.  People
   # who want LTO need to use --with-lto themselves.
   DEF_MAKE_ALL_RULE="profile-opt"
   REQUIRE_PGO="yes"

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list