[Python-checkins] cpython (3.5): Issue #25366: Skip test_with_pip when threading module is not available

berker.peksag python-checkins at python.org
Mon Jan 18 19:02:10 EST 2016


https://hg.python.org/cpython/rev/2a201272daed
changeset:   99969:2a201272daed
branch:      3.5
parent:      99967:7215d13baa2d
user:        Berker Peksag <berker.peksag at gmail.com>
date:        Tue Jan 19 02:01:53 2016 +0200
summary:
  Issue #25366: Skip test_with_pip when threading module is not available

Some dependencies of pip import threading module unconditionally so
we need to skip the test to make buildbots happy.

files:
  Lib/test/test_venv.py |  7 +++++++
  1 files changed, 7 insertions(+), 0 deletions(-)


diff --git a/Lib/test/test_venv.py b/Lib/test/test_venv.py
--- a/Lib/test/test_venv.py
+++ b/Lib/test/test_venv.py
@@ -25,6 +25,11 @@
 except ImportError:
     ssl = None
 
+try:
+    import threading
+except ImportError:
+    threading = None
+
 skipInVenv = unittest.skipIf(sys.prefix != sys.base_prefix,
                              'Test not appropriate in a venv')
 
@@ -319,6 +324,8 @@
 
     # Requesting pip fails without SSL (http://bugs.python.org/issue19744)
     @unittest.skipIf(ssl is None, ensurepip._MISSING_SSL_MESSAGE)
+    @unittest.skipUnless(threading, 'some dependencies of pip import threading'
+                                    ' module unconditionally')
     def test_with_pip(self):
         rmtree(self.env_dir)
         with EnvironmentVarGuard() as envvars:

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list