[Python-checkins] cpython (3.4): Issue #17753: Skip test_zipfile tests which require write access to test
serhiy.storchaka
python-checkins at python.org
Sat Feb 14 22:17:57 CET 2015
https://hg.python.org/cpython/rev/6ad5909319e0
changeset: 94617:6ad5909319e0
branch: 3.4
parent: 94614:ae5d868513fd
user: Serhiy Storchaka <storchaka at gmail.com>
date: Sat Feb 14 23:04:35 2015 +0200
summary:
Issue #17753: Skip test_zipfile tests which require write access to test
and email.test.
files:
Lib/test/test_zipfile.py | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/Lib/test/test_zipfile.py b/Lib/test/test_zipfile.py
--- a/Lib/test/test_zipfile.py
+++ b/Lib/test/test_zipfile.py
@@ -648,7 +648,12 @@
if name + 'o' not in namelist:
self.assertIn(name + 'c', namelist)
+ def requiresWriteAccess(self, path):
+ if not os.access(path, os.W_OK, effective_ids=True):
+ self.skipTest('requires write access to the installed location')
+
def test_write_pyfile(self):
+ self.requiresWriteAccess(os.path.dirname(__file__))
with TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
fn = __file__
if fn.endswith('.pyc') or fn.endswith('.pyo'):
@@ -680,6 +685,7 @@
def test_write_python_package(self):
import email
packagedir = os.path.dirname(email.__file__)
+ self.requiresWriteAccess(packagedir)
with TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
zipfp.writepy(packagedir)
@@ -693,6 +699,7 @@
def test_write_filtered_python_package(self):
import test
packagedir = os.path.dirname(test.__file__)
+ self.requiresWriteAccess(packagedir)
with TemporaryFile() as t, zipfile.PyZipFile(t, "w") as zipfp:
@@ -721,6 +728,7 @@
def test_write_with_optimization(self):
import email
packagedir = os.path.dirname(email.__file__)
+ self.requiresWriteAccess(packagedir)
# use .pyc if running test in optimization mode,
# use .pyo if running test in debug mode
optlevel = 1 if __debug__ else 0
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list