[Python-checkins] cpython (2.7): Issue #24751: When running regrtest with '-w', don't fail if re-run succeeds.

zach.ware python-checkins at python.org
Wed Aug 5 05:00:19 CEST 2015


https://hg.python.org/cpython/rev/6987a9c7dde9
changeset:   97257:6987a9c7dde9
branch:      2.7
user:        Zachary Ware <zachary.ware at gmail.com>
date:        Tue Aug 04 21:53:21 2015 -0500
summary:
  Issue #24751: When running regrtest with '-w', don't fail if re-run succeeds.

files:
  Lib/test/regrtest.py |  11 ++++++++---
  Misc/NEWS            |   7 +++++++
  2 files changed, 15 insertions(+), 3 deletions(-)


diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py
--- a/Lib/test/regrtest.py
+++ b/Lib/test/regrtest.py
@@ -652,7 +652,7 @@
 
     if verbose2 and bad:
         print "Re-running failed tests in verbose mode"
-        for test in bad:
+        for test in bad[:]:
             print "Re-running test %r in verbose mode" % test
             sys.stdout.flush()
             try:
@@ -662,8 +662,13 @@
                 # print a newline separate from the ^C
                 print
                 break
-            except:
-                raise
+            else:
+                if ok[0] in {PASSED, ENV_CHANGED, SKIPPED, RESOURCE_DENIED}:
+                    bad.remove(test)
+        else:
+            if bad:
+                print count(len(bad), "test"), "failed again:"
+                printlist(bad)
 
     if single:
         if next_single_test:
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -149,6 +149,13 @@
 - Issue #22155: Add File Handlers subsection with createfilehandler to Tkinter
   doc.  Remove obsolete example from FAQ.  Patch by Martin Panter.
 
+Tests
+-----
+
+- Issue #24751: When running regrtest with the ``-w`` command line option,
+  a test run is no longer marked as a failure if all tests succeed when
+  re-run.
+
 
 What's New in Python 2.7.10?
 ============================

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list