[Python-checkins] cpython (2.7): Issue #22201: Command-line interface of the zipfile module now correctly

serhiy.storchaka python-checkins at python.org
Sun Aug 17 14:20:26 CEST 2014


http://hg.python.org/cpython/rev/ffa5bfe75c3a
changeset:   92130:ffa5bfe75c3a
branch:      2.7
user:        Serhiy Storchaka <storchaka at gmail.com>
date:        Sun Aug 17 15:11:06 2014 +0300
summary:
  Issue #22201: Command-line interface of the zipfile module now correctly
extracts ZIP files with directory entries.  Patch by Ryan Wilson.

files:
  Lib/zipfile.py |  13 +------------
  Misc/NEWS      |   6 ++++++
  2 files changed, 7 insertions(+), 12 deletions(-)


diff --git a/Lib/zipfile.py b/Lib/zipfile.py
--- a/Lib/zipfile.py
+++ b/Lib/zipfile.py
@@ -1492,18 +1492,7 @@
             sys.exit(1)
 
         with ZipFile(args[1], 'r') as zf:
-            out = args[2]
-            for path in zf.namelist():
-                if path.startswith('./'):
-                    tgt = os.path.join(out, path[2:])
-                else:
-                    tgt = os.path.join(out, path)
-
-                tgtdir = os.path.dirname(tgt)
-                if not os.path.exists(tgtdir):
-                    os.makedirs(tgtdir)
-                with open(tgt, 'wb') as fp:
-                    fp.write(zf.read(path))
+            zf.extractall(args[2])
 
     elif args[0] == '-c':
         if len(args) < 3:
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -84,6 +84,12 @@
   adds support for the Linux AArch64 and POWERPC ELF ABIv2 little endian
   architectures.
 
+Tools/Demos
+-----------
+
+- Issue #22201: Command-line interface of the zipfile module now correctly
+  extracts ZIP files with directory entries.  Patch by Ryan Wilson.
+
 Tests
 -----
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list