[Python-checkins] cpython (merge 3.2 -> default): os.popen().close() returns None on success, not 0...

charles-francois.natali python-checkins at python.org
Wed May 2 20:52:17 CEST 2012


http://hg.python.org/cpython/rev/d7779f783ae2
changeset:   76719:d7779f783ae2
parent:      76715:982c30064bc9
parent:      76718:26c1a1f29e1e
user:        Charles-François Natali <neologix at free.fr>
date:        Wed May 02 20:50:13 2012 +0200
summary:
  os.popen().close() returns None on success, not 0...

files:
  Lib/test/test_posix.py |  4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -630,7 +630,7 @@
             groups = idg.read().strip()
             ret = idg.close()
 
-        if ret != 0 or not groups:
+        if ret != None or not groups:
             raise unittest.SkipTest("need working 'id -G'")
 
         self.assertEqual(
@@ -644,7 +644,7 @@
             groups = idg.read().strip()
             ret = idg.close()
 
-        if ret != 0 or not groups:
+        if ret != None or not groups:
             raise unittest.SkipTest("need working 'id -G'")
 
         # 'id -G' and 'os.getgroups()' should return the same

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list