[Python-checkins] cpython (3.2): Issue #15726: Fix incorrect bounds checking in PyState_FindModule.
antoine.pitrou
python-checkins at python.org
Mon Aug 20 19:38:27 CEST 2012
http://hg.python.org/cpython/rev/b96a4b1e7ecb
changeset: 78677:b96a4b1e7ecb
branch: 3.2
parent: 78674:d5ee1a06101f
user: Antoine Pitrou <solipsis at pitrou.net>
date: Mon Aug 20 19:30:46 2012 +0200
summary:
Issue #15726: Fix incorrect bounds checking in PyState_FindModule.
Patch by Robin Schreiber.
files:
Misc/ACKS | 1 +
Misc/NEWS | 3 +++
Python/pystate.c | 2 +-
3 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/Misc/ACKS b/Misc/ACKS
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -848,6 +848,7 @@
Michael Schneider
Peter Schneider-Kamp
Arvin Schnell
+Robin Schreiber
Chad J. Schroeder
Sam Schulenburg
Stefan Schwarzer
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@
Core and Builtins
-----------------
+- Issue #15726: Fix incorrect bounds checking in PyState_FindModule.
+ Patch by Robin Schreiber.
+
- Issue #15604: Update uses of PyObject_IsTrue() to check for and handle
errors correctly. Patch by Serhiy Storchaka.
diff --git a/Python/pystate.c b/Python/pystate.c
--- a/Python/pystate.c
+++ b/Python/pystate.c
@@ -248,7 +248,7 @@
return NULL;
if (state->modules_by_index == NULL)
return NULL;
- if (index > PyList_GET_SIZE(state->modules_by_index))
+ if (index >= PyList_GET_SIZE(state->modules_by_index))
return NULL;
res = PyList_GET_ITEM(state->modules_by_index, index);
return res==Py_None ? NULL : res;
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list