[Python-checkins] devguide: Merge

[antoine.pitrou]

antoine.pitrou pushed ec3d7e79f9e2 to devguide:

http://hg.python.org/devguide/rev/ec3d7e79f9e2
changeset:   272:ec3d7e79f9e2
branch:      hg_transition
parent:      270:570a452dc4d9
parent:      271:a90309bc93fb
user:        Antoine Pitrou <solipsis at pitrou.net>
date:        Mon Feb 07 22:11:50 2011 +0100
summary:
  Merge

files:
  patch.rst

diff --git a/patch.rst b/patch.rst
--- a/patch.rst
+++ b/patch.rst
@@ -53,9 +53,14 @@
 Third, make sure you have proper tests to verify your patch works as expected.
 Patches will not be accepted without the proper tests!
 
-Fourth, proper documentation additions/changes should be included.
+Fourth, make sure the entire test suite :ref:`runs <runtests>` **without
+failure** because of your changes.  It is not sufficient to only run whichever
+test seems impacted by your changes, because there might be interferences
+unknown to you between your changes and some other part of the interpreter.
 
-Fifth, if you are not already in the ``Misc/ACKS`` file then add your name. If
+Fifth, proper documentation additions/changes should be included.
+
+Sixth, if you are not already in the ``Misc/ACKS`` file then add your name. If
 you have taken the time to diagnose a problem, invent a solution, code it up,
 and submit a patch you deserve to be recognized as having contributed to
 Python. This also means you need to fill out a `contributor form`_ which
@@ -72,12 +77,6 @@
 Generation
 ''''''''''
 
-Before creating your patch, you should make sure that the entire test suite
-:ref:`runs <runtests>` without failure because of your changes.  It is not
-sufficient to only run whichever test seems impacted by your changes, because
-there might be interferences unknown to you between your changes and some
-other part of the interpreter.
-
 To perform a quick sanity check on your patch, you can run::
 
     make patchcheck

--
Repository URL: http://hg.python.org/devguide