[Python-checkins] r87368 - in python/branches/py3k: Lib/test/test_descr.py Misc/NEWS Objects/descrobject.c
ezio.melotti
python-checkins at python.org
Sat Dec 18 15:59:44 CET 2010
Author: ezio.melotti
Date: Sat Dec 18 15:59:43 2010
New Revision: 87368
Log:
#5587: add a repr to dict_proxy objects. Patch by David Stanek and Daniel Urban.
Modified:
python/branches/py3k/Lib/test/test_descr.py
python/branches/py3k/Misc/NEWS
python/branches/py3k/Objects/descrobject.c
Modified: python/branches/py3k/Lib/test/test_descr.py
==============================================================================
--- python/branches/py3k/Lib/test/test_descr.py (original)
+++ python/branches/py3k/Lib/test/test_descr.py Sat Dec 18 15:59:43 2010
@@ -4268,6 +4268,11 @@
pass
self.assertEqual(type(C.__dict__), type(B.__dict__))
+ def test_repr(self):
+ # Testing dict_proxy.__repr__
+ dict_ = {k: v for k, v in self.C.__dict__.items()}
+ self.assertEqual(repr(self.C.__dict__), 'dict_proxy({!r})'.format(dict_))
+
class PTypesLongInitTest(unittest.TestCase):
# This is in its own TestCase so that it can be run before any other tests.
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS (original)
+++ python/branches/py3k/Misc/NEWS Sat Dec 18 15:59:43 2010
@@ -17,6 +17,9 @@
rather than the Py_IsInitialized flag, avoiding a Fatal Python
error in certain circumstances when an import is done in __del__.
+- Issue #5587: add a repr to dict_proxy objects. Patch by David Stanek and
+ Daniel Urban.
+
Library
-------
Modified: python/branches/py3k/Objects/descrobject.c
==============================================================================
--- python/branches/py3k/Objects/descrobject.c (original)
+++ python/branches/py3k/Objects/descrobject.c Sat Dec 18 15:59:43 2010
@@ -766,6 +766,12 @@
return PyObject_Str(pp->dict);
}
+static PyObject *
+proxy_repr(proxyobject *pp)
+{
+ return PyUnicode_FromFormat("dict_proxy(%R)", pp->dict);
+}
+
static int
proxy_traverse(PyObject *self, visitproc visit, void *arg)
{
@@ -791,7 +797,7 @@
0, /* tp_getattr */
0, /* tp_setattr */
0, /* tp_reserved */
- 0, /* tp_repr */
+ (reprfunc)proxy_repr, /* tp_repr */
0, /* tp_as_number */
&proxy_as_sequence, /* tp_as_sequence */
&proxy_as_mapping, /* tp_as_mapping */
More information about the Python-checkins
mailing list